Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot upload a directory if its name contains a single quote #10191

Closed
cyberduck opened this issue Jan 10, 2018 · 10 comments
Closed

Cannot upload a directory if its name contains a single quote #10191

cyberduck opened this issue Jan 10, 2018 · 10 comments
Labels
bug fixed googledrive Google Drive Protocol Implementation low priority
Milestone

Comments

@cyberduck
Copy link
Collaborator

11bfe86 created the issue

This issue is specifically about Google Drive. I tried the same scenario on a FTP server and it worked.

  • On local computer, create a directory containing a single quote in its name (e.g. foo'bar)
  • Put some file in the directory. There is no issue if the directory is empty.
  • Drag'n'drop the directory to your Google Drive.

Here is the encountered error:

Listing directory failed (/My Drive/Music backups). [[br]] Invalid Value. Bad Request. Please contact your web hosting service provider for assistance. [[br]] Continue

The directory itself is created, but not its contents. I can also navigate into the directory (but of course it is empty).

Cyberduck 6.3.3 / Windows 7 64-bit

@cyberduck
Copy link
Collaborator Author

@dkocher commented

Related to #9792.

@cyberduck
Copy link
Collaborator Author

11bfe86 commented

I have just encountered the same issue with character "À". Interestingly, it works with e.g. "é", so it's about accentuated uppercase. Also note the error message is different:
File not found [[br]] /My Drive/Music backups/foo À bar. Please contact your web hosting service provider for assistance. [[br]] Continue

Also, I have the setting "Uploads: Preserve modification date" enabled (which btw doesn't affect the issue) and I just noticed files with quotes or "À", etc. in their names don't have their timestamp corrected.

@cyberduck
Copy link
Collaborator Author

11bfe86 commented

I searched a bit about this, and it's a known issue in Google Drive...

Then I found, more interesting:

@cyberduck
Copy link
Collaborator Author

@dkocher commented

Replying to [comment:3 Vh1F8t3vYxtu]:

I searched a bit about this, and it's a known issue in Google Drive...

Then I found, more interesting:

Thanks for digging into this!

@cyberduck
Copy link
Collaborator Author

11bfe86 commented

I guess the first part of the workaround would go to https://g.iterate.ch/projects/ITERATE/repos/cyberduck/browse/googledrive/src/main/java/ch/cyberduck/core/googledrive/FileidDriveListService.java11951.

But I haven't figured out how to add the subsequent "filter false positives" part.

Probably, a developer of Cyberduck could easily solve this :)

@cyberduck
Copy link
Collaborator Author

11bfe86 commented

On June, Google marked issue 64468406 as resolved, but it's only partially fixed:

  • fixed: folder name with accents
  • not fixed: folder name with single quotes (and folder not empty)

Thus, I'm kindly asking to consider implementing the workaround I linked to above.

This way, we wouldn't depend on Google to fix the bug on their side, waiting for months/years, if ever they fix it some day...

@cyberduck
Copy link
Collaborator Author

@dkocher commented

Duplicate for #9792.

@cyberduck
Copy link
Collaborator Author

@dkocher commented

In 6d8024a.

@cyberduck
Copy link
Collaborator Author

11bfe86 commented

Just to point out a few more changes have been made in addition to 6d8024a. There is also the subsequent 2b276b0, and more tests have been added in 9c53794 and 7cd5432.

@cyberduck
Copy link
Collaborator Author

@dkocher commented

Replying to [comment:11 Vh1F8t3vYxtu]:

Just to point out a few more changes have been made in addition to 6d8024a. There is also the subsequent 2b276b0, and more tests have been added in 9c53794 and 7cd5432.
Thanks for keeping track of these additional changes.

@iterate-ch iterate-ch locked as resolved and limited conversation to collaborators Nov 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug fixed googledrive Google Drive Protocol Implementation low priority
Projects
None yet
Development

No branches or pull requests

1 participant