Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving files internally within OneDrive writes to the URL/percent encoded destination path #10313

Closed
cyberduck opened this issue May 1, 2018 · 1 comment
Assignees
Labels
bug fixed onedrive OneDrive Protocol Implementation
Milestone

Comments

@cyberduck
Copy link
Collaborator

1254f97 created the issue

When a file is moved within OneDrive to a destination directory that contains whitespace the file is instead written to the URL-encoded destination path (i.e. spaces are replaced with %20). This only occurs with internal moves from one directory in OneDrive to another directory in OneDrive.

Scope

  • Affects move by drag and drop in Cyberduck as well as Cmd + dnd and the mv command in Mountain Duck
  • Affects the Duplicate command in Cyberduck
  • Does not seem to affect copying or creating files, only moving and duplicating
  • Does not affect files moved into OneDrive from elsewhere on the filesystem
  • Does not affect other providers (tested Dropbox)

Steps to reproduce

Moving

  1. Connect to a OneDrive account
  2. Create a target directory with whitespace if none already exists (e.g. "Camera Roll")
  3. Move any file from the OneDrive account into the target directory
  4. Sign in to onedrive.com in a browser to verify the moved file

Duplicating

  1. Connect to a OneDrive account
  2. Create a target directory with whitespace if none already exists (e.g. "Camera Roll")
  3. Create a file in the directory if necessary
  4. Use the context menu option to Duplicate the file
  5. Sign in to onedrive.com in a browser to verify the duplicated file

Observations

Note that in both cases

  1. A new directory has been created based on the percent encoding of the target directory (e.g. "Camera%20Roll")
  2. The file does not exist in the actual target directory
  3. Encoding is additive, i.e. moving a file into "Camera%20Roll" creates a "Camera%2520Roll" double-encoded directory
  4. If using Mountain Duck, Finder may show a placeholder for the file in the target directory, a file named ? that is visible until the directory is reloaded

Versions

I have verified this in Cyberduck 6.4.6 (27773), 6.5.0 (27854), and Mountain Duck 2.4.0 (9334) with the Cryptomator integration enabled.

@cyberduck
Copy link
Collaborator Author

@dkocher commented

In 11d495f.

@iterate-ch iterate-ch locked as resolved and limited conversation to collaborators Nov 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug fixed onedrive OneDrive Protocol Implementation
Projects
None yet
Development

No branches or pull requests

2 participants