New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lazily calculate signed URLs for menu items #10329
Comments
Also occurring on other platforms (Mac OS X, Linux) and I can confirm it is on account of pre-signed URL generation from S3. |
I encountered this today. repro:
The following versions might not be relevant but it wouldn't surprise me if either or both were required to reproduce my experience with high fidelity:
|
Current Behavior
Copy URL shows the URL text for each and every file selected. If there are too many files selected, this could freeze, hang or crash Cyberduck. To recover, I have to use Task Manager to kill Cyberduck process and run the application again.
-Expected Behavior*
Copy URL should show the URL text for the first file only. Even if there are many files selected, the menu should appear fast and not freeze application.
-Note:* This may appear related to the Amazon S3 bucket's special "Pre-signed URL" which could take a long time to generate for multiple files, especially with 3 different versions. Suggest it to be generated for first file only, and when the option to copy it is selected, then use an async progress dialog to generate for all selected files and copy to clipboard.
There could also be an option to show generic fixed fake examples in the menu, instead of generating the real examples from the selected files. This will ensure the menu appears instantly, and the real URLs need only be generated for the selected format after the selection was made.
The text was updated successfully, but these errors were encountered: