Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bookmarks translated string shared for 2 different purposes (preventing good translation) #10434

Closed
cyberduck opened this issue Aug 16, 2018 · 1 comment
Assignees
Milestone

Comments

@cyberduck
Copy link
Collaborator

12d27f1 created the issue

Hello,

While proofreading and correcting the localization, I noticed that the translation for word "Bookmarks" appear 3 times in Cyberduck translation files (that's OK).

But one of those 3 definitions (the one in the file "Localizable") seems to be used twice:
1- to write "Bookmarks" as tooltip of the icon in the main windows
2- to concat the bookmark number and write "X Bookmarks" in the footer of the main windows

For the translators, it would be better not to share the same string for those 2 different purposes (since in some languages, you have an uppercase initial as first word, but you have to avoid it afterwards).

Moreover (to write "X Bookmarks"), I wonder if the right string to use would not be the word "Bookmarks" defined in the localization file "Browser"?

Another way, to separate the string used for "X Bookmarks" (in the footer) from the string used for "Bookmarks" (in the tooltip), it could be possible to define a new string "{0} Bookmarks" for the footer since it already exists a string "{0} files" for the footer: that would be harmonized.

Best regards

@cyberduck
Copy link
Collaborator Author

@dkocher commented

In dec611c.

@iterate-ch iterate-ch locked as resolved and limited conversation to collaborators Nov 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants