Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Windows Credential Manager support #11699

Closed
cyberduck opened this issue Jun 7, 2021 · 2 comments
Closed

Improve Windows Credential Manager support #11699

cyberduck opened this issue Jun 7, 2021 · 2 comments
Assignees
Labels
Milestone

Comments

@cyberduck
Copy link
Collaborator

@AliveDevil created the issue

Current Windows Credential Manager implementation splits OAuth Access and Refresh Token into two separate entries in Windows Credential Manager - this should ideally be one single entry.

Windows Credential Manager limits passwords to be max size of CRED_MAX_CREDENTIAL_BLOB_SIZE (512) bytes - this is problematic as AAD OAuth tokens easily exceed 512 Bytes.

Leverage use of CredentialAttribute which allows page sizes of CRED_MAX_VALUE_SIZE (256) bytes, with up to CRED_MAX_ATTRIBUTES (64) pages - this would allow storing 16 KiB of data in a Windows Credential Manager-entry - resulting in one entry per OAuth Access/Refresh-Token. Additional metadata can be stored as well (token expiry) as this is currently not handled correctly.

For this to work we rely on the CSWin32- and Win32Metadata-projects to leave Preview (Win32Metadata) and Beta (CSWin32) state and release a stable build.

@cyberduck
Copy link
Collaborator Author

@AliveDevil commented

Current implementation

@AliveDevil
Copy link
Contributor

Done. #12918

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants