Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Illegal characters in path crashes application #11911

Closed
cyberduck opened this issue Nov 16, 2021 · 5 comments · Fixed by #12590
Closed

Illegal characters in path crashes application #11911

cyberduck opened this issue Nov 16, 2021 · 5 comments · Fixed by #12590
Assignees
@AliveDevil
Labels
bug googledrive Google Drive Protocol Implementation
Milestone
8.1.1

Comments

@cyberduck
Copy link
Collaborator

1c70021 created the issue

Everytime I try to access a folder in Drive (Usually just the top level "My Drive" to start), Cyberduck crashes. No problems authenticating with Google, and I can actually browse around a bit inside Drive with the "Do you want to report the latest crash" dialogue window open.

Not sure if anything I can send/show can help, if so let me know and I'll upload asap.

Attachments
@cyberduck
Copy link
Collaborator Author

adc75a0 commented

I can't reproduce the described crashes on my side.

Please share the latest crash report with us. Crash reports are saved to %AppData%\Cyberduck\CrashReporter.

@cyberduck
Copy link
Collaborator Author

1c70021 commented

Attached the crash report as well as a gif of what happens. Steps to reproduce are exactly that, just trying to access My Drive crashes the application.

@cyberduck
Copy link
Collaborator Author

@dkocher commented

1	-----------------------------
2	[General Info]
3	
4	Application: Cyberduck
5	Version:     8.0.2.36345
6	Region:      English (United States)
7	Date: 11/16/2021
8	Time: 6:27 PM
9	
10	User Explanation:
11	
12	User said ""
13	-----------------------------
14	
15	[Exception Info 1]
16	
17	Top-level Exception
18	Type:        System.ArgumentException
19	Message:     Illegal characters in path.
20	Source:      mscorlib
21	Stack Trace: at System.IO.Path.CheckInvalidPathChars(String path, Boolean checkAdditional)
22	   at System.IO.Path.GetExtension(String path)
23	   at Ch.Cyberduck.Core.Refresh.Services.IconProvider`1.GetFileIcon(String filename, Boolean isFolder, Boolean large, Boolean isExecutable)
24	   at Ch.Cyberduck.Core.Refresh.Services.WinFormsIconProvider.GetPath(Path path, Int32 size)
25	   at BrightIdeasSoftware.ObjectListView.MakeSubItem(Object rowObject, OLVColumn column)
26	   at BrightIdeasSoftware.ObjectListView.FillInValues(OLVListItem lvi, Object rowObject)
27	   at BrightIdeasSoftware.VirtualObjectListView.MakeListViewItem(Int32 itemIndex)
28	   at BrightIdeasSoftware.TreeListView.MakeListViewItem(Int32 itemIndex)
29	   at BrightIdeasSoftware.VirtualObjectListView.HandleRetrieveVirtualItem(Object sender, RetrieveVirtualItemEventArgs e)
30	   at System.Windows.Forms.ListView.OnRetrieveVirtualItem(RetrieveVirtualItemEventArgs e)
31	   at System.Windows.Forms.ListView.WmReflectNotify(Message& m)
32	   at System.Windows.Forms.ListView.WndProc(Message& m)
33	   at System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)

@cyberduck
Copy link
Collaborator Author

@AliveDevil commented

Do you have any file containing any of these reserved characters in its filename or file extension?

Naming Files, Paths, and Namespaces/Naming Conventions

@cyberduck
Copy link
Collaborator Author

@dkocher commented

Ticket retargeted after milestone closed

@AliveDevil AliveDevil mentioned this issue Nov 30, 2021
Merged
@CodeShakingSheep CodeShakingSheep mentioned this issue Jan 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AliveDevil AliveDevil

Labels
bug googledrive Google Drive Protocol Implementation
Projects
None yet
Milestone
8.1.1
Development

Successfully merging a pull request may close this issue.

Dont rely on Path.GetExtension iterate-ch/cyberduck
2 participants
@AliveDevil @cyberduck