Cyberduck Mountain Duck CLI

Opened 11 years ago

Closed 11 years ago

Last modified 10 years ago

#1244 closed defect (fixed)

Leopard: Saving file in external editor doesn't cause upload

Reported by: danwood Owned by: dkocher
Priority: high Milestone: 2.8.1
Component: core Version: 2.8
Severity: normal Keywords: leopard
Cc: Architecture:
Platform:

Description (last modified by dkocher)

Using Leopard (9A527) and CyberDuck 2.8b1 (3212)/3212, and SubEthaEdit as an external editor, I notice that when editing a file and saving back, the file is not re-uploaded.

This is logged to the console:

9/10/07 12:58:29 PM Cyberduck[1178] handleModifiedFileEvent: Got ODB editor event for unknown file. 
9/10/07 12:58:30 PM Cyberduck[1178] handleClosedFileEvent: Got ODB editor event for unknown file. 


Change History (18)

comment:1 Changed 11 years ago by dkocher

  • Description modified (diff)
  • Milestone set to 2.8.1
  • Status changed from new to assigned

comment:2 Changed 11 years ago by dkocher

  • Priority changed from normal to high

comment:3 Changed 11 years ago by andyfowler

Just wanted to confirm that this is still occurring in final release. Tested using CyberDuck 2.8 r3257 and TextMate.

comment:4 Changed 11 years ago by jduffas

I confirm : same problem, with any text editor.

comment:5 Changed 11 years ago by paodj

  • Milestone 2.8.1 deleted
  • Version changed from 2.7.3 to 2.8

I've the same problem with leopard final (golden master) with bbedit.

comment:6 Changed 11 years ago by paodj

  • Milestone set to 2.8.1

comment:7 Changed 11 years ago by GREENSKiN

Confirmed under Leopard retail, with CyberDuck 2.8 (3257) and TextMate 1.5.7 (1436).

comment:8 Changed 11 years ago by GREENSKiN

I inserted some debug code in the source... I think Leopard reports symlinks in a different way than Tiger did:

10/28/07 9:52:23 PM Cyberduck[13529] handleModifiedFileEvent: Got ODB editor event for unknown file (/private/var/folders/wO/wOFigXmSH9ykExpUW4b+qU+++TI/-Tmp-/var/www/test-3.php). 10/28/07 9:52:23 PM Cyberduck[13529] Dictionary contains... {

"/var/folders/wO/wOFigXmSH9ykExpUW4b+qU+++TI/-Tmp-/var/www/test-3.php" = {

ODBEditorFileName = "/var/folders/wO/wOFigXmSH9ykExpUW4b+qU+++TI/-Tmp-/var/www/test-3.php"; ODBEditorIsEditingString = 0; ODBEditorNonRetainedClient = <10291000>;

};

}

As you can see TextMate reports /private/var/... for the filename, whereas Cyberduck has stored /var/... in its dictionary object.

comment:9 Changed 11 years ago by GREENSKiN

Patch!

\214c214
< 			[_filesBeingEdited setObject: dictionary forKey: [fileName stringByResolvingSymlinksInPath]];
---
> 			[_filesBeingEdited setObject: dictionary forKey: fileName];
233c233
< 	dictionary = [_filesBeingEdited objectForKey: [fileName stringByResolvingSymlinksInPath]];
---
> 	dictionary = [_filesBeingEdited objectForKey: fileName];
254c254
< 	dictionary = [_filesBeingEdited objectForKey: [fileName stringByResolvingSymlinksInPath]];
---
> 	dictionary = [_filesBeingEdited objectForKey: fileName];

comment:10 Changed 11 years ago by jduffas

how do you patch the app ? would you put somewhere the app patched ?

jean

comment:11 Changed 11 years ago by andyfowler

The patch from greenskin works great, though he forgot to mention the file to be patched:

cyberduck/source/ch/cyberduck/ui/cocoa/odb/ODBEditor.m

I've applied his patch to the latest svn version and compiled it as a temporary fix for anybody interested. Not sure if it's compatible with 10.4 but it works great in 10.5.

http://www.createarevolution.com/downloads/cyberduck-r3260-10.5.zip

comment:12 Changed 11 years ago by dkocher

Thanks for the patch! I will test under 10.3.9-10.5 and then apply. You will find the latest build at http://update.cyberduck.ch/nightly/ then.

comment:13 Changed 11 years ago by dkocher

I have added a cyberduck-dev mailing list to make it easier to discuss code. See #1202.

comment:14 Changed 11 years ago by dkocher

  • Resolution set to fixed
  • Status changed from assigned to closed

In r3263.

comment:16 Changed 11 years ago by chuckienorton

I just downloaded the new build & still cannot even select an editor. (using leopard). Am I missing something?? Thanks, -Chuck

comment:17 Changed 11 years ago by GoClick

It would be nice if that build were available by update in the client I didn't like having to search around in trac to find it. glas it's here though

comment:18 Changed 11 years ago by dkocher

An official release is due soon but there are one or two other issues I want to have resolved first. Thanks for your patience.

Note: See TracTickets for help on using tickets.
swiss made software