Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bonjour installation is not optional, can't be removed via normal means #13416

Closed
savchenko opened this issue May 30, 2022 · 3 comments · Fixed by #14630
Closed

Bonjour installation is not optional, can't be removed via normal means #13416

savchenko opened this issue May 30, 2022 · 3 comments · Fixed by #14630
Assignees
@AliveDevil
Labels
installer Windows Installer
Milestone
8.6.0

Comments

@savchenko
Copy link

Describe the bug
Bonjour installation isn't optional anymore, it can't be removed manually from "Apps & Features" or a "classic" Control panel.

To Reproduce
Steps to reproduce the behavior:

  1. Download Cyberduck-Installer-8.3.3.37544.exe
  2. Try to install without Bonjour
  3. Realise it's not optional, try to uninstall the Bonjour without wiping the Cyberduck

Expected behavior
Make Bonjour optional as per ee952d1 and allow it to be uninstalled as per #10850

Screenshots

Cyberduck installed

image

Installer options

image

Desktop (please complete the following information):

  • OS: Windows 10 21H2
  • Version: 10.0.19044 Build 19044

Log Files
N/A

Additional context
See the linked issue & commit.
@dkocher dkocher added the installer Windows Installer label May 30, 2022
@leifcr
Copy link

leifcr commented Jan 11, 2023 •
edited

This was originally fixed in #5563 back in 2010, but has sneak back it seems.

Workaround to stop the service:

  1. Run services.msc
  2. Right click Bonjour service, click properties
  3. Set startup to manual or deactivated
  4. Stop the service (Right click + stop)

At least that disables for now.

@AliveDevil AliveDevil mentioned this issue May 8, 2023
Merged
@AliveDevil
Copy link
Contributor

After merge Bonjour is removed automatically through auto-update. Installing Bonjour requires either running the installer again with the Bonjour checkbox selected (default), or installing Bonjour manually.

@dkocher dkocher added this to the 8.6.0 milestone May 8, 2023
@AliveDevil
Copy link
Contributor

Reviewed this, new behavior will be:

  • Bonjour is opt-out (Options -> Bonjour checkbox)
  • On Update, the installer checks for an existing Bonjour installation, and keeps the installation alive
  • If Bonjour is removed after Cyberduck got installed, any future update won't install Bonjour again
  • After merge the update should make Bonjour visible in Programs & Features
  • For automated installations the property Cyberduck-Installer.exe InstallBonjour=0 can be used.

dkocher added a commit that referenced this issue May 10, 2023
@dkocher
Merge pull request #14630 from iterate-ch/bugfix/GH-13416
5b41b4c 
Make Bonjour optional & visible in apps & programs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AliveDevil AliveDevil

Labels
installer Windows Installer
Projects
None yet
Milestone
8.6.0
Development

Successfully merging a pull request may close this issue.

Make Bonjour optional & visible in apps & programs iterate-ch/cyberduck
4 participants
@dkocher @savchenko @leifcr @AliveDevil