@dkocher commented

What is the error message in Cyberduck (if any)? Please paste here to output of the 'ls' command when connecting with 'ftp' from the Terminal.app.

7c2cf62 commented

I was playing around a bit with this, I posted my comments to : http://forums.cocoaforge.com/viewtopic.php?p=9956199561

I think this issue is the same as : 1302 and 1172

7c2cf62 commented

FILE:
FTPControlSocket.java

FUNCTIONS:
createDataSocket() -> createDataSocketPASV()

PROBLEM DESCRIPTION:
"new FTPPassiveDataSocket(new Socket(ipAddress, port));"
This line of code is causing trouble. In case of passive mode "new Socket" might time out. In that casel a ConnectException is thrown. This exception is not taken to consideration. The 'fallback' is only watching 'FTPException' which in this case is not thrown, therefore there is no fallback to 'active' mode.

SUGGESTION:
imho the current implementation is not taking care of the timeout. To my understanding, according to j2se/1.4.2/docs/api/java/net/Socket.html#setSoTimeout(int), it would be possible to get a java.net.SocketTimeoutException.

I'm not a huge java developer so this is just a suggestion, please drop it if it's not useful.

7c2cf62 commented

I've spent some time with inspecting this further on. As I googled it, it seems it's impossible to set timeout for a new Socket, so here the code always have to wait 60 seconds. The setSoTimeout(int) or the socket.connect(ip, timeout), effects only already opened connections. Unfortunately in this case no specific exception is thrown, but ConnectException. ConnectException != TimeoutException, but maybe in this specific case it could be used to start a 'fallback' for the other type of connection. If both active and passive fails with ConnectException, a specific flag could be set, and user could be informed that there was a ConnectExcepion?

@dkocher commented

Applied (modified) patch in 7efa100.