Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ftp MLST used despite compatibility protocol (FTP) #14333

Closed
Schaefers opened this issue Mar 9, 2023 · 7 comments · Fixed by #14336 or #14346
Closed

Ftp MLST used despite compatibility protocol (FTP) #14333

Schaefers opened this issue Mar 9, 2023 · 7 comments · Fixed by #14336 or #14346
Assignees
@dkocher
Labels
bug ftp FTP Protocol Implementation thirdparty Issue caused by third party
Milestone
8.5.7

Comments

@Schaefers
Copy link

Describe the bug
I'm trying to upload the folder containing other folders and files via FTP. According to the logs there's an issue with the 250-Status response, maybe it's wrongly sent by the server. Testing with a different FTP client worked, though.

Screenshots
Attached screenshots of the ftpd server.

Desktop (please complete the following information):

  • OS: macOS
  • Version 13.2.1

Log Files
cyberduck.log

Additional context
Add any other context about the problem here.
IMG_B948C8971E7B-1
@AliveDevil
Copy link
Contributor

Unfortunately that isn't an error in itself - just noise.

We'd need the debug log to check further here.
Please provide the log as attachment here (use the web ui, e-mail attachments don't work) or as separate e-mail to support@cyberduck.io mention "Github 14333".

To summarize:
You upload a folder with files to a FTP server, after completing the transfers shows incomplete?

@AliveDevil AliveDevil self-assigned this Mar 9, 2023
@AliveDevil AliveDevil added help wanted ftp FTP Protocol Implementation labels Mar 9, 2023
@Schaefers
Copy link
Author

Unfortunately that isn't an error in itself - just noise.

We'd need the debug log to check further here. Please provide the log as attachment here (use the web ui, e-mail attachments don't work) or as separate e-mail to support@cyberduck.io mention "Github 14333".

To summarize: You upload a folder with files to a FTP server, after completing the transfers shows incomplete?

I'm trying to copy the attached folder (just zipped it to upload here) and Cyberduck is just creating the empty folder on the ftp. Screenshot of Transfers attached.

image

010012F017576000.zip

cyberduck.log

@AliveDevil
Copy link
Contributor 

2023-03-09 14:16:45,469 [Thread-45] INFO  ch.cyberduck.transcript.request - MLST /010012F017576000
2023-03-09 14:16:45,472 [Thread-45] INFO  ch.cyberduck.transcript.response - 250-Status
 /010012F017576000
250 End

Your FTP server isn't standards1 compliant.

Please report this issue to your ftp server vendor.
In the meantime use the "FTP Compatibility"-protocol, which can be installed in the preferences2, to workaround this.

Footnotes

  1. https://www.rfc-editor.org/rfc/rfc3659#section-7.7.2 ↩

  2. https://docs.cyberduck.io/protocols/#preferences-profiles ↩

@Schaefers
Copy link
Author

Thank you! I'll raise an issue in their issue tracker.

Sadly the "FTP Compatibility"-protocol didn't fix it, I'm still getting "Transfer incomplete" and it's still using MLST command.

I deleted the log and tried transferring again:

cyberduck.log

@AliveDevil AliveDevil changed the title Transfer incomplete when transferring nested folder via FTP Ftp MLST used despite compatibility protocol (FTP) Mar 9, 2023
@Schaefers Schaefers mentioned this issue Mar 9, 2023
Closed
@AliveDevil
Copy link
Contributor

We are, despite disabling MLS*, still trying to use MLST if the server announces it.

cyberduck/ftp/src/main/java/ch/cyberduck/core/ftp/FTPAttributesFinderFeature.java

Line 59 in c52332e

if(session.getClient().hasFeature(FTPCmd.MLST.getCommand())) {

Unfortunately, there is nothing you can do to workaround this now.

@AliveDevil AliveDevil added the bug label Mar 9, 2023
@Schaefers
Copy link
Author

Unfortunately, there is nothing you can do to workaround this now.

I can still create it folder by folder 😊 Thanks for tracking the issue down!

@AliveDevil AliveDevil added thirdparty Issue caused by third party and removed help wanted labels Mar 9, 2023
@AliveDevil AliveDevil mentioned this issue Mar 9, 2023
Merged
@AliveDevil AliveDevil assigned dkocher and unassigned AliveDevil Mar 9, 2023
@AliveDevil
Copy link
Contributor

@dkocher Failing test for you. #14336

@AliveDevil AliveDevil added this to the 8.5.7 milestone Mar 9, 2023
dkocher added a commit that referenced this issue Mar 13, 2023
@dkocher
Do not use MLST when running with interoperability connection profile. …
12644a7 
…Fix #14333.
@dkocher dkocher mentioned this issue Mar 13, 2023
Merged
ylangisc added a commit that referenced this issue Mar 14, 2023
@ylangisc
Merge pull request #14346 from iterate-ch/bugfix/GH-14333-preferences
2ec93d2 
Do not use MLST when running with interoperability connection profile…
dkocher added a commit that referenced this issue May 27, 2023
@dkocher
Merge pull request #14336 from iterate-ch/bugfix/GH-14333
1aa6d79 
Fix bad formatted MLST reply
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dkocher dkocher

Labels
bug ftp FTP Protocol Implementation thirdparty Issue caused by third party
Projects
None yet
Milestone
8.5.7
3 participants
@dkocher @AliveDevil @Schaefers