Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide directory placeholders only containing hidden files #14431

Merged
merged 5 commits into from Mar 27, 2023

Conversation

dkocher
Copy link
Contributor

@dkocher dkocher commented Mar 27, 2023

No description provided.

@dkocher dkocher added cryptomator Cryptomator Vault b2 Backblaze B2 Protocol Implementation labels Mar 27, 2023
@dkocher dkocher added this to the 8.5.8 milestone Mar 27, 2023
@dkocher dkocher requested a review from a team as a code owner March 27, 2023 07:17
@dkocher dkocher changed the title Bugfix/md 18435 Hide directory placeholders only containing hidden files Mar 27, 2023
@ylangisc ylangisc merged commit 88aa52a into master Mar 27, 2023
5 checks passed
@ylangisc ylangisc deleted the bugfix/MD-18435 branch March 27, 2023 12:00
@Cherry
Copy link

Cherry commented Apr 12, 2023

This PR appears to have caused a large performance regression when listing large B2 buckets. I'm confirming and creating an issue now.

@metadaddy
Copy link

metadaddy commented Jun 7, 2023

I'm not sure that it's possible to successfully implement this functionality. Consider a bucket with millions of objects with keys of the form folder00000001/foo, folder00000002/foo, folder00000003/foo, etc. This is not a particularly contrived example - analytical data can have this kind of structure. Every 'folder name' will need to be inspected, via a B2 API call, to determine whether it should be shown.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
b2 Backblaze B2 Protocol Implementation cryptomator Cryptomator Vault
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants