Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unresponsive on FTP server drop out #15671

Closed
AliveDevil opened this issue Feb 29, 2024 · 3 comments · Fixed by #15677
Closed

Unresponsive on FTP server drop out #15671

AliveDevil opened this issue Feb 29, 2024 · 3 comments · Fixed by #15677
Assignees
@dkocher
Labels
ftp FTP Protocol Implementation interface User Interface
Milestone
8.8.0

Comments

@AliveDevil
Copy link
Contributor

When a download transfer is in progress (multiple connections, segmented) the moment the FTP server fails (IP available, Port dead) the macOS app becomes unresponsive.

Spindump.txt
@AliveDevil AliveDevil added interface User Interface ftp FTP Protocol Implementation labels Feb 29, 2024
@AliveDevil
Copy link
Contributor Author

threaddump-1709213262090.tdump.txt

@dkocher
Copy link
Contributor

dkocher commented Mar 2, 2024

The thread dump shows that the main thread is waiting for all transfer threads to complete.

	at ch.cyberduck.core.threading.ExecutorServiceThreadPool.shutdown(ExecutorServiceThreadPool.java:50)
	at ch.cyberduck.core.worker.ConcurrentTransferWorker.shutdown(ConcurrentTransferWorker.java:183)
	at ch.cyberduck.core.worker.AbstractTransferWorker.cleanup(AbstractTransferWorker.java:548)
	at ch.cyberduck.core.worker.AbstractTransferWorker.cleanup(AbstractTransferWorker.java:53)
	at ch.cyberduck.core.threading.TransferWorkerBackgroundAction.cleanup(TransferWorkerBackgroundAction.java:67)
	at ch.cyberduck.core.threading.TransferCollectionBackgroundAction.cleanup(TransferCollectionBackgroundAction.java:90)
	at ch.cyberduck.ui.cocoa.controller.TransferController$8.cleanup(TransferController.java:624)

Regression from 238ac9c.

@dkocher
Copy link
Contributor

dkocher commented Mar 2, 2024

Was previously fixed in fa618e5.

@dkocher dkocher added this to the 8.8.0 milestone Mar 2, 2024
dkocher added a commit that referenced this issue Mar 2, 2024
@dkocher
Fix #15671.
fef39f4
@dkocher dkocher linked a pull request Mar 2, 2024 that will close this issue
Fix #15671. #15677
Merged
ylangisc added a commit that referenced this issue Mar 4, 2024
@ylangisc
Merge pull request #15677 from iterate-ch/bugfix/GH-15671
52a7d58 
Fix #15671.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dkocher dkocher

Labels
ftp FTP Protocol Implementation interface User Interface
Projects
None yet
Milestone
8.8.0
Development

Successfully merging a pull request may close this issue.

Fix #15671. iterate-ch/cyberduck
2 participants
@dkocher @AliveDevil