Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opening new connection with URL that contains trailing white space fails #2812

Closed
cyberduck opened this issue Dec 16, 2008 · 1 comment
Closed
Assignees
Labels
bug fixed webdav WebDAV Protocol Implementation
Milestone

Comments

@cyberduck
Copy link
Collaborator

gnaegi created the issue

In our system the generate the WebDAV URL so that users can copy/paste it to their WebDAV client. When doing a dripple click to select the entire URL at once some whitespace after the URL with line breaks is also marked. I did not realize this, copied it to the Cyberduck new connection dialog and got the following error while connecting:

PROPFIND /myurl/webdav%0A HTTP/1.1[\r][\n]
Authorization: Basic Z25hZWdpOmhpaGkx[\r][\n]
Content-Type: text/xml; charset=utf-8[\r][\n]
User-Agent: Cyberduck/3.0.3 (4205)[\r][\n]
Host: www.myhost.com[\r][\n]
Content-Length: 207[\r][\n]
Depth: 0[\r][\n]
[\r][\n]
HTTP/1.1 501 Not Implemented[\r][\n]
HTTP/1.1 501 Not Implemented[\r][\n]
Date: Tue, 16 Dec 2008 16:47:18 GMT[\r][\n]
Server: Apache/2.0.53 (Linux/SUSE)[\r][\n]
Content-Length: 1238[\r][\n]
Connection: close[\r][\n]
Content-Type: text/html;charset=utf-8[\r][\n]
[\r][\n]

The %0A at the end of the URL triggered the problem. I guess all you need to do is to call url.trim() to make the new connection dialog a bit more robust against user errors.

Thanks!
Florian Gnägi
http://www.frentix.com

@cyberduck
Copy link
Collaborator Author

@dkocher commented

Fixed in f2a1a00.

@iterate-ch iterate-ch locked as resolved and limited conversation to collaborators Nov 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug fixed webdav WebDAV Protocol Implementation
Projects
None yet
Development

No branches or pull requests

2 participants