Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Directory listing cache for transfer leads to out of memory. #3331

Closed
cyberduck opened this issue Jul 15, 2009 · 1 comment
Closed

Directory listing cache for transfer leads to out of memory. #3331

cyberduck opened this issue Jul 15, 2009 · 1 comment

Comments

@cyberduck
Copy link
Collaborator

e94c21b created the issue

Kept failing when downloading a 50 MB website:

I/O Error: Download failed
<path of failed file>
Unexpected end of sftp stream..													

I couldn't figure out why 'till I searched through the system.log and found this:

Jul 15 12:53:15 external-4 [0x0-0xf04f04].ch.sudo.cyberduck[67034]: Exception in thread "Background" java.lang.OutOfMemoryError: Java heap space
Jul 15 12:53:15 external-4 [0x0-0xf04f04].ch.sudo.cyberduck[67034]:     at org.apache.commons.collections.map.AbstractHashedMap.<init>(AbstractHashedMap.java:152)
Jul 15 12:53:15 external-4 [0x0-0xf04f04].ch.sudo.cyberduck[67034]:     at org.apache.commons.collections.map.AbstractLinkedMap.<init>(AbstractLinkedMap.java:109)
Jul 15 12:53:15 external-4 [0x0-0xf04f04].ch.sudo.cyberduck[67034]:     at org.apache.commons.collections.map.LRUMap.<init>(LRUMap.java:126)
Jul 15 12:53:15 external-4 [0x0-0xf04f04].ch.sudo.cyberduck[67034]:     at org.apache.commons.collections.map.LRUMap.<init>(LRUMap.java:111)
Jul 15 12:53:15 external-4 [0x0-0xf04f04].ch.sudo.cyberduck[67034]:     at org.apache.commons.collections.map.LRUMap.<init>(LRUMap.java:86)
Jul 15 12:53:15 external-4 [0x0-0xf04f04].ch.sudo.cyberduck[67034]:     at ch.cyberduck.core.Cache$1.<init>(Cache.java:39)
Jul 15 12:53:15 external-4 [0x0-0xf04f04].ch.sudo.cyberduck[67034]:     at ch.cyberduck.core.Cache.<init>(Cache.java:37)
Jul 15 12:53:15 external-4 [0x0-0xf04f04].ch.sudo.cyberduck[67034]:     at ch.cyberduck.core.Local.<init>(Local.java:327)
Jul 15 12:53:15 external-4 [0x0-0xf04f04].ch.sudo.cyberduck[67034]:     at ch.cyberduck.core.Local.<init>(Local.java:219)
Jul 15 12:53:15 external-4 [0x0-0xf04f04].ch.sudo.cyberduck[67034]:     at ch.cyberduck.core.DownloadTransfer.childs(DownloadTransfer.java:190)
Jul 15 12:53:15 external-4 [0x0-0xf04f04].ch.sudo.cyberduck[67034]:     at ch.cyberduck.core.SyncTransfer.childs(SyncTransfer.java:200)
Jul 15 12:53:15 external-4 [0x0-0xf04f04].ch.sudo.cyberduck[67034]:     at ch.cyberduck.core.Transfer.prepare(Transfer.java:612)
Jul 15 12:53:15 external-4 [0x0-0xf04f04].ch.sudo.cyberduck[67034]:     at ch.cyberduck.core.Transfer.prepare(Transfer.java:613)
Jul 15 12:53:15 external-4 [0x0-0xf04f04].ch.sudo.cyberduck[67034]:     at ch.cyberduck.core.Transfer.transfer(Transfer.java:573)
Jul 15 12:53:15 external-4 [0x0-0xf04f04].ch.sudo.cyberduck[67034]:     at ch.cyberduck.core.Transfer.start(Transfer.java:671)
Jul 15 12:53:15 external-4 [0x0-0xf04f04].ch.sudo.cyberduck[67034]:     at ch.cyberduck.ui.cocoa.CDTransferController$4.run(CDTransferController.java:581)
Jul 15 12:53:15 external-4 [0x0-0xf04f04].ch.sudo.cyberduck[67034]:     at ch.cyberduck.ui.cocoa.CDWindowController$1.run(CDWindowController.java:77)

I'm guessing this is why it kept failing.

If the app can't run because of a memory shortage, it should tell the user. I'm using version 3.2.1, but it's not an option. On the current OS (10.5.7).

See disputedly closed Ticket #2645.

@cyberduck
Copy link
Collaborator Author

@dkocher commented

Fixed in dbe58ee. Cache is limited to browser.cache.size (currently 1000) directory listings.

@iterate-ch iterate-ch locked as resolved and limited conversation to collaborators Nov 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants