#29561 closed enhancement (fixed)
Don't use imports from rings.all in matrices
Reported by: | tscrim | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-9.1 |
Component: | refactoring | Keywords: | |
Cc: | caruso | Merged in: | |
Authors: | Travis Scrimshaw | Reviewers: | Xavier Caruso |
Report Upstream: | N/A | Work issues: | |
Branch: | eac641b (Commits, GitHub, GitLab) | Commit: | eac641bce2a25db908fe6a88126fac4c885ef61f |
Dependencies: | Stopgaps: |
Description (last modified by )
This can cause import loops that are not naturally there when importing matrices at the top-level in skew polynomials. See, e.g., #21264
Change History (7)
comment:1 Changed 18 months ago by
- Branch set to u/tscrim/specific_imports_matrices-29561
- Commit set to eac641bce2a25db908fe6a88126fac4c885ef61f
- Description modified (diff)
- Status changed from new to needs_review
comment:2 Changed 18 months ago by
- Reviewers set to Xavier Caruso
I know that they are not related to your changes but maybe you could also fix the pyflakes issues reported by the patchbot in this ticket:
git checkout patchbot/ticket_merged src/sage/matrix/benchmark.py:145: local variable 'v' is assigned to but never used src/sage/matrix/benchmark.py:184: local variable 'v' is assigned to but never used src/sage/matrix/benchmark.py:223: local variable 'v' is assigned to but never used src/sage/matrix/benchmark.py:261: local variable 'v' is assigned to but never used src/sage/matrix/benchmark.py:301: local variable 'v' is assigned to but never used src/sage/matrix/benchmark.py:343: local variable 'v' is assigned to but never used src/sage/matrix/benchmark.py:387: local variable 'v' is assigned to but never used src/sage/matrix/benchmark.py:452: local variable 'd' is assigned to but never used src/sage/matrix/benchmark.py:492: local variable 'd' is assigned to but never used src/sage/matrix/benchmark.py:536: local variable 'w' is assigned to but never used src/sage/matrix/benchmark.py:615: local variable 'v' is assigned to but never used src/sage/matrix/benchmark.py:654: local variable 'v' is assigned to but never used src/sage/matrix/benchmark.py:692: local variable 'v' is assigned to but never used src/sage/matrix/benchmark.py:738: local variable 'v' is assigned to but never used src/sage/matrix/benchmark.py:778: local variable 'v' is assigned to but never used src/sage/matrix/benchmark.py:814: local variable 'v' is assigned to but never used src/sage/matrix/benchmark.py:851: local variable 'd' is assigned to but never used src/sage/matrix/benchmark.py:913: local variable 'v' is assigned to but never used src/sage/matrix/benchmark.py:952: local variable 'v' is assigned to but never used src/sage/matrix/benchmark.py:994: local variable 'v' is assigned to but never used src/sage/matrix/benchmark.py:1035: local variable 'd' is assigned to but never used src/sage/matrix/benchmark.py:1069: local variable 'd' is assigned to but never used src/sage/matrix/benchmark.py:1107: local variable 'w' is assigned to but never used src/sage/matrix/benchmark.py:1160: local variable 'v' is assigned to but never used src/sage/matrix/benchmark.py:1200: local variable 'v' is assigned to but never used src/sage/matrix/matrix_integer_dense_hnf.py:17: 'sage.rings.rational_field.QQ' imported but unused
Apart from this, everything looks good to me.
comment:3 Changed 18 months ago by
Does this ticket fix a bug and should go into 9.1?
comment:4 Changed 18 months ago by
No, it does not really fix a bug. I think it can wait for 9.2.
comment:5 Changed 18 months ago by
- Status changed from needs_review to positive_review
comment:6 Changed 18 months ago by
- Branch changed from u/tscrim/specific_imports_matrices-29561 to eac641bce2a25db908fe6a88126fac4c885ef61f
- Resolution set to fixed
- Status changed from positive_review to closed
comment:7 Changed 18 months ago by
- Milestone changed from sage-9.2 to sage-9.1
Note: See
TracTickets for help on using
tickets.
Hopefully this will help untangle a bit of Sage's import hell too.
New commits:
Making imports more local in matrices.