Cyberduck Mountain Duck CLI

Opened 8 years ago

Closed 8 years ago

#5142 closed defect (fixed)

kSCPropNetProxiesExceptionsList processing ignored CIDR styled patterns

Reported by: https://www.google.com/accounts/o8/id?id=aitoawlacyi7aiogipgx3ujwq77gimjemieww8s Owned by: dkocher
Priority: low Milestone: 3.8
Component: core Version: 3.6
Severity: normal Keywords:
Cc: Architecture:
Platform:

Description (last modified by dkocher)

In ch/cyberduck/core/SystemconfigurationProxy.m, in method

+ (BOOL)isHostExcluded:(NSString *)hostname

it ignores the CIDR styled pattern such as 192.168/16 or 172.16/16 or 10/8, would it be possible to include it? This will make proxy exception handling more complete.

Cheers,

Change History (8)

comment:1 Changed 8 years ago by dkocher

  • Description modified (diff)
  • Milestone set to 4.0
  • Status changed from new to assigned

comment:2 Changed 8 years ago by dkocher

  • Milestone changed from 4.0 to 4.1

Can you provide a patch?

comment:3 Changed 8 years ago by dkocher

  • Priority changed from normal to low

comment:4 Changed 8 years ago by dkocher

We should also better parse the setting for general hostnames.

  • To bypass a single domain, enter the domain name, for example, apple.com.
  • To bypass all websites on a domain, use an asterisk before the domain name, for example, *.apple.com.
  • To bypass a specific part of a domain, specify each part, for example, store.apple.com.

comment:5 Changed 8 years ago by dkocher

We should also read kSCPropNetProxiesExcludeSimpleHostnames.

comment:6 Changed 8 years ago by dkocher

  • Milestone changed from 4.1 to 4.0

Fix general failures to obey host exclusion setting for HTTP proxies in r7776.

comment:7 in reply to: ā†‘Ā description Changed 8 years ago by dkocher

Replying to https://www.google.com/accounts/o8/id?id=aitoawlacyi7aiogipgx3ujwq77gimjemieww8s:

it ignores the CIDR styled pattern such as 192.168/16 or 172.16/16 or 10/8, would it be possible to include it? This will make proxy exception handling more complete.

I can make use of ā€‹SubnetUtil to detect these, but it will only recognize patterns matching n.n.n.n/m where n=1-3 decimal digits, m = 1-3 decimal digits in range 1-32.

comment:8 Changed 8 years ago by dkocher

  • Resolution set to fixed
  • Status changed from assigned to closed

In r7778.

Note: See TracTickets for help on using tickets.
swiss made software