Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bookmark with public key still prompts for password #5987

Closed
cyberduck opened this issue Jun 2, 2011 · 1 comment
Closed

Bookmark with public key still prompts for password #5987

cyberduck opened this issue Jun 2, 2011 · 1 comment
Assignees
Labels
enhancement fixed sftp SFTP Protocol Implementation
Milestone

Comments

@cyberduck
Copy link
Collaborator

9f13418 created the issue

I have an SFTP bookmark set up with a public key. Neither the public key nor the account I'm connecting to requires a password, but double-clicking the bookmark brings up the login sheet anyway. (Pressing "Login" without entering a password then works fine.)

This is because the decision whether or not to prompt a user for a password currently depends on whether or not keychain use is enabled. But the information about public keys is stored outside the keychain.

Patch attached, but I'm new to development here so I don't know if this is complete. In particular, I have no idea how to write a test for this.


Attachments

@cyberduck
Copy link
Collaborator Author

@dkocher commented

Thanks for the patch. In 8219117.

@iterate-ch iterate-ch locked as resolved and limited conversation to collaborators Nov 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement fixed sftp SFTP Protocol Implementation
Projects
None yet
Development

No branches or pull requests

2 participants