Permissions not preserved when editing remote file via sftp connection

[majashdown]

When editing a remote file via an sftp connection, the permissions of the file are not preserved when uploading the file. They are always reset to rw-r--r--. This always happens, regardless of the settings in the Transfers preferences.

This behaviour does not happen in version 4.3.1.

[dkocher]

In r13733 and r13736.

[michael vöhringer]

I can reproduce this but with the latest Snapshot (14063). Is this fixed in v 14063 ?

[dkocher]

Replying to michael vöhringer:

I can reproduce this but with the latest Snapshot (14063). Is this fixed in v 14063 ?

On Windows?

[michael vöhringer]

no, its OSX 10.9

[dkocher]

Additional fix when local filesystem does not support UNIX permissions in r14079.

[dkocher]

Replying to michael vöhringer:

no, its OSX 10.9

I cannot reproduce the issue on OS X with build 14063 and later.

[dkocher]

Please post the transcript from the log drawer (⌘-L).

[michael vöhringer]

How to reproduce:

• Open sftp connection to remote host (linux)
• create a file test.txt
• change the owner of the file to something different (for example www-data if you are connected as root via sftp)
• Open the file with the "editor"-icon in cyberduck
• save the file.

-> on my system the owner changed from www-data to root and the permission to "-rw-r--r--" after saving the file

SSH_FXP_READDIR
SSH_FXP_STATUS
SSH_FXP_CLOSE
SSH_FXP_STATUS
SSH_FXP_OPEN
SSH_FXP_HANDLE
SSH_FXP_READ
SSH_FXP_DATA
SSH_FXP_READ
SSH_FXP_STATUS
SSH_FXP_CLOSE
SSH_FXP_STATUS
SSH_FXP_STAT
SSH_FXP_ATTRS
SSH_FXP_STAT
SSH_FXP_ATTRS
SSH_FXP_OPEN
SSH_FXP_HANDLE
SSH_FXP_WRITE
SSH_FXP_STATUS
SSH_FXP_CLOSE
SSH_FXP_STATUS
SSH_FXP_STAT
SSH_FXP_ATTRS
SSH_FXP_REMOVE
SSH_FXP_STATUS
SSH_FXP_RENAME
SSH_FXP_STATUS
SSH_FXP_SETSTAT
SSH_FXP_STATUS

[michael vöhringer]

FYI: i can not reproduce this, if i only download/upload the file.

[dkocher]

Thanks for the transcript. We see one SSH_FXP_SETSTAT being sent after the upload is complete. We would expect it two times, once to set the timestamp and once for the permissions.

[dkocher]

I can reproduce this only when setting Preferences → Uploads → Change permissions → to these permissions: and uncheck all checkboxes. With this setting no permissions are updated after the upload is complete.

[dkocher]

Can you find any error output in the system.log (/Applications/Utilities/Console.app) from Cyberduck?

[michael vöhringer]

• Change Permission is not set
• No errors in the log

Anything else i can check?

[dkocher]

Thanks for the screenshot. You will have to set Change permissions for Downloads otherwise the edited file will have the default mode 644 on OS X.

[dkocher]

Replying to dkocher:

Thanks for the transcript. We see one SSH_FXP_SETSTAT being sent after the upload is complete. We would expect it two times, once to set the timestamp and once for the permissions.

Actually expected because setting the timestamp explicitly for uploads is disabled by default.

[michael vöhringer]

ok, the permissions are stable after i set Download->Change permissions, but the user of the online-file changed. I can reproduce this only if use the edit function within cyberduck. When download/upload via drag&drop the permission/user/group did not change online.

Permission before editing the file:

-rw------- 1 www-data root   41 Nov 20 17:20 test.txt

Permission after saving the file in Sublime

-rw------- 1 root root   47 Nov 20 17:23 test.txt

[dkocher]

Replying to michael vöhringer:

ok, the permissions are stable after i set Download->Change permissions, but the user of the online-file changed. I can reproduce this only if use the edit function within cyberduck. When download/upload via drag&drop the permission/user/group did not change online.

Permission before editing the file:

-rw------- 1 www-data root   41 Nov 20 17:20 test.txt

Permission after saving the file in Sublime

-rw------- 1 root root   47 Nov 20 17:23 test.txt

Yes, this is expected because of the temporary rename feature enabled by default for edits. See ​hidden property editor.upload.temporary to disable the use of temporary name on upload when uploading changes from the editor on save.

defaults write ch.sudo.cyberduck editor.upload.temporary false

[dkocher]

Handling of file owner related to #15.

[michael vöhringer]

thank you very much, after setting "editor.upload.temporary false" the edit works as (I) expected. Now the behavior of V 4.3 is back.

[daniel bleisch]

Still doesn't work with 4.4.3.

"defaults write ch.sudo.cyberduck editor.upload.temporary false"

helps to prevent the file-owner, but still changes the permissions from 0755 to 0644.

[dkocher]

In r14207.