Cyberduck Mountain Duck CLI

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#7641 closed defect (fixed)

Corrupted files downloaded

Reported by: michael smith Owned by: dkocher
Priority: high Milestone: 4.4.3
Component: sftp Version: 4.4.2
Severity: critical Keywords: encoding
Cc: Architecture: Intel
Platform: Mac OS X 10.7

Description

In trying to move a web site from one server to another we discovered that some of the files were trashed once they got there. We tracked it down to downloading under version 4.4.2. I've attached one of the files that was getting trashed - both the original and the trashed version. The end of the downloaded file is messed up with random bytes. It could be something like a file encoding issue, but the files should be utf8 which is what 'default' used.

  • The process was downloading from a linux server to a mac. Then uploading to a new linux server. But the file is corrupted on the initial download. Also doing an Edit (which downloads the file to textmate) shows the file as corrupt.
  • The file is not actually corrupted on the server. SSH in and cat the file shows it correctly.
  • It's not random. The same files will trash the same exact way each time we download them. Even if they are in different folders. So we suspect it has to do with the contents of the file or the order of the characters or the length of the files. But we don't know.
  • These are text files. PHP code and java. But also we did see a .zip file got corrupted on download. But not every zip. Not every text file. About 10 in 200 files on my particular web site.
  • We tried from two different macs with two different versions of OS - downloading from the same server. One mac is 10.7.5. Don't know the other one version. Both macs with cyberduck 4.4.2 trash those particular files.
  • Using either ForkLift or Cyberduck (13582) 4.4.1 the file downloads correctly with the same settings from that same server.
  • We also tried from two different linux servers. Using 4.4.2 that file is always corrupt in the same way, coming down from either of my servers. The servers are both CENTOS 6.4 x86_64 standard but are located in different states and have different versions of OS. One has webmin installed and one has cpanel installed.

Attachments (1)

cyberduck_prob.zip (20.1 KB) - added by michael smith 5 years ago.
example of a file that gets corrupted - both the original and corrupted versions

Download all attachments as: .zip

Change History (13)

Changed 5 years ago by michael smith

example of a file that gets corrupted - both the original and corrupted versions

comment:1 Changed 5 years ago by dkocher

  • Milestone set to 4.5
  • Owner set to dkocher
  • Status changed from new to assigned

comment:2 Changed 5 years ago by dkocher

What protocol do you use to connect to the server?

comment:3 Changed 5 years ago by dkocher

Can you please post the transcript from the log drawer (⌘-L) of the Transfers window for such a corrupt download.

comment:4 Changed 5 years ago by dkocher

  • Milestone changed from 4.5 to 4.4.3

comment:5 Changed 5 years ago by dkocher

  • Component changed from core to sftp
  • Summary changed from Version 4.4.2 trashing files to Corrupted files downloaded

comment:6 Changed 5 years ago by dkocher

  • Component changed from sftp to core

The regression must have been introduced in r14072. Added test in r14117.

comment:7 Changed 5 years ago by dkocher

Rewrote more tests for coverage in r14120.

comment:8 Changed 5 years ago by dkocher

Added failing test in r14125.

comment:9 Changed 5 years ago by dkocher

Fixed in r14118 by removing buffers.

Last edited 5 years ago by dkocher (previous) (diff)

comment:10 Changed 5 years ago by dkocher

  • Resolution set to fixed
  • Status changed from assigned to closed

Additional fix in r14127 by always reading full chunk size.

comment:11 Changed 5 years ago by dkocher

  • Component changed from core to sftp

comment:12 Changed 5 years ago by dkocher

#7656 closed as duplicate.

Note: See TracTickets for help on using tickets.
swiss made software