Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upload strategy when editing remote file should be configurable #7827

Closed
cyberduck opened this issue Feb 28, 2014 · 3 comments
Closed

Upload strategy when editing remote file should be configurable #7827

cyberduck opened this issue Feb 28, 2014 · 3 comments
Assignees
@dkocher
Labels
enhancement webdav WebDAV Protocol Implementation worksforme
Milestone
4.4.4

Comments

@cyberduck
Copy link
Collaborator

40a7a8d created the issue

When remote file that has been fetched for editing is uploaded back to a WebDAV server, Cyberduck does the file name shuffle (PUT / MOVE) (for safety? HTTP exchange example is below). Perhaps, this behaviour should be configurable; i.e. a user should be able to choose in prefs whether the shuffle is performed or the file is uploaded (PUT) directly.

The reason for this suggestion is that WebDAV server may not be be able to retain versioning information for the target file when such a shuffle is performed.

In my case, it is the WebDAV interface of the Box.com service. When edited file is put back on box.com server, file versioning information is lost.

PUT /dav/Stuff/Leo%20Ent%20Invoice%20No1.docx-f040baf0-5c30-45b4-8ab0-f697e42ba6d6 HTTP/1.1
Expect: 100-continue
Content-Length: 68151
Content-Type: application/vnd.openxmlformats-officedocument.wordprocessingml.document
Host: dav.box.com
Connection: Keep-Alive
User-Agent: Cyberduck/4.4.3 (Mac OS X/10.9.2) (x86_64)
Authorization: Basic xxxxx
HTTP/1.1 201 Created
Server: nginx
Date: Fri, 28 Feb 2014 20:43:03 GMT
Content-Type: text/html; charset=UTF-8
Content-Length: 0
Connection: keep-alive
ETag: "db66b2b5448ed1e752e80a493a9c850d7ada59be"


MOVE /dav/Stuff/Leo%20Ent%20Invoice%20No1.docx-f040baf0-5c30-45b4-8ab0-f697e42ba6d6 HTTP/1.1
Destination: https://dav.box.com/dav/Stuff/Leo%20Ent%20Invoice%20No1.docx
Overwrite: T
Host: dav.box.com
Connection: Keep-Alive
User-Agent: Cyberduck/4.4.3 (Mac OS X/10.9.2) (x86_64)
Authorization: Basic xxxxx
HTTP/1.1 204 No Content
Server: nginx
Date: Fri, 28 Feb 2014 20:43:05 GMT
Content-Type: text/html; charset=UTF-8
Content-Length: 0
Connection: keep-alive
Vary: Host

HEAD /dav/Stuff/Leo%20Ent%20Invoice%20No1.docx HTTP/1.1
Host: dav.box.com
Connection: Keep-Alive
User-Agent: Cyberduck/4.4.3 (Mac OS X/10.9.2) (x86_64)
Authorization: Basic xxxxxx
HTTP/1.1 200 OK
Server: nginx
Date: Fri, 28 Feb 2014 20:44:14 GMT
Content-Type: application/vnd.openxmlformats-officedocument.wordprocessingml.document
Content-Length: 68151
Connection: keep-alive
Vary: Host
Last-Modified: Fri, 28 Feb 2014 20:43:04 GMT
ETag: "db66b2b5448ed1e752e80a493a9c850d7ada59be"
@cyberduck
Copy link
Collaborator Author

40a7a8d commented

Could someone familiar with the code base point me to the relevant parts of the code? I'd like to attempt a patch if no one takes this ticket on.

@cyberduck
Copy link
Collaborator Author

@dkocher commented

This is now documented in Disable upload of temporary file on save.

@cyberduck
Copy link
Collaborator Author

40a7a8d commented

This is awesome; thanks for documenting this. Shall I file a separate ticket to bring this setting into the settings GUIs?

@iterate-ch iterate-ch locked as resolved and limited conversation to collaborators Nov 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dkocher dkocher

Labels
enhancement webdav WebDAV Protocol Implementation worksforme
Projects
None yet
Milestone
4.4.4
Development

No branches or pull requests
2 participants
@dkocher @cyberduck