Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failure to retry transfer with network failure #8182

Closed
cyberduck opened this issue Aug 17, 2014 · 8 comments
Closed

Failure to retry transfer with network failure #8182

cyberduck opened this issue Aug 17, 2014 · 8 comments
Labels
bug core fixed
Milestone
4.5.2

Comments

@cyberduck
Copy link
Collaborator

fafb52e created the issue

Hi Devs,
For an unknown reason to me (may be because of my ISP), my idle connections get dropped automatically.
It is very annoying when I am using CyberDuck to develop code remotely and after sometime I try to save a file but not only it is unsuccessful, it needs a lot of effort to re-establish the connection and retry to save the file.
Here is what happens after I click save button :\
1.For about 5-10 seconds cyberduck hangs in Preparing file mode. Here is a screenshot :\
external image\\
2.Then I receive the following error with 2 options. no matter which option I choose, it doesnt re-establish the connection and just gives the message "Transfer incomplete"\
external image\\
3.At this point you have no choice but to try to disconnect manually, but when I click on disconnect button I receive the following error. Clicking on Try again just gives the same error message again and again and you have to Cancel.\
external image\\
4.After you cancel, then you have to make a change in your file ! and try to save again. now it retries to re-establish the connection and save the file.

I would appreciate if you can somehow resolve this issue. One obvious and easy solution is to keep the connection alive by sending NOP messages to server in regular intervals. it not only keeps the connection alive but also even if connection is dropped for any reason, cyberdock would be able to detect it and re-establish the connection in background. Currently it seems to me that cyberduck is clueless about the state of connection.

Thanks
@cyberduck
Copy link
Collaborator Author

@dkocher commented

The Try Again option that does not take effect has been fixed in d4af5cc.

@cyberduck
Copy link
Collaborator Author

fafb52e commented

I have revision dc41874 installed. so it is not fixed in d4af5cc.

@cyberduck
Copy link
Collaborator Author

fafb52e commented

Hi David ,
Is there any particular reason for not implementing keep alive function ? because even if you fix "Try Again" option, it means cyberduck will hang for 5-10 seconds until it detects there is something wrong with connection and then try to re-establish the connection which includes all authentication and so on which is another 5 seconds. it means every save will take 10-15 seconds. Why not to prevent the problem instead of trying to fix it every time ?
connection keep alive is standard feature of good FTP clients and other similar products like webdrive already have this feature.

@cyberduck
Copy link
Collaborator Author

@dkocher commented

Other related patch in ea49689.

@cyberduck
Copy link
Collaborator Author

@dkocher commented

Replying to [comment:5 FiFtHeLeMeNt]:

Hi David ,
Is there any particular reason for not implementing keep alive function ? because even if you fix "Try Again" option, it means cyberduck will hang for 5-10 seconds until it detects there is something wrong with connection and then try to re-establish the connection which includes all authentication and so on which is another 5 seconds. it means every save will take 10-15 seconds. Why not to prevent the problem instead of trying to fix it every time ?
connection keep alive is standard feature of good FTP clients and other similar products like webdrive already have this feature.

We will consider adding an idle connection check for FTP connections. This is already implemented for SFTP with version 4.5.

@cyberduck
Copy link
Collaborator Author

@dkocher commented

Disable alert callback for editor in 1792cf9.

@cyberduck
Copy link
Collaborator Author

@dkocher commented

Handle reconnect in 19bdb5b.

@cyberduck
Copy link
Collaborator Author

@dkocher commented

Replying to [comment:7 dkocher]:

Replying to [comment:5 FiFtHeLeMeNt]:

Hi David ,
Is there any particular reason for not implementing keep alive function ? because even if you fix "Try Again" option, it means cyberduck will hang for 5-10 seconds until it detects there is something wrong with connection and then try to re-establish the connection which includes all authentication and so on which is another 5 seconds. it means every save will take 10-15 seconds. Why not to prevent the problem instead of trying to fix it every time ?
connection keep alive is standard feature of good FTP clients and other similar products like webdrive already have this feature.

We will consider adding an idle connection check for FTP connections. This is already implemented for SFTP with version 4.5.

Now in #9075.

@iterate-ch iterate-ch locked as resolved and limited conversation to collaborators Nov 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug core fixed
Projects
None yet
Milestone
4.5.2
Development

No branches or pull requests
1 participant
@cyberduck