You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When creating a bookmark with a '/' character in the nickname field, Cyberduck will fail to allow you to drag the file to the Finder.
Unfortunately, it does not give any indication that it has failed, it simply doesn't create the file.
-(Additional testing shows that if a folder matching the pre-/ portion of the nickname exists, Cyberduck will create a file inside that folder with only the post-/ portion of the nickname as the bookmark filename. - I.e. Cyberduck is not escaping path components well in its file creation/naming routine.)*
The fix would appear to simply be checking for the '/' character in nicknames before completing the drag operation and converting any and all of them that are found into ':' characters (which the Finder represents as '/' to the user) so that the bookmark is created in the expected location with it's appropriate name.
-(Bookmarks with ':' characters might ought to be a special case too due to their special history as path separators in old Mac OS versions... but they appear to work just fine as is and merely appear in the Finder with a '/' instead of the ':' as might be expected anyway. So it isn't really "necessary" to handle them in any special way.)*
Optionally, if there is some exceptional problem I haven't foreseen in fixing this, then there should at the very least be a warning message generated by Cyberduck if dragging the bookmark fails. Currently, absolutely nothing happens at the end of the drag operation, and that is not good for the user experience.
The text was updated successfully, but these errors were encountered:
Actually, I suppose this should have been marked for the interface component. And I hope this is minor enough of a fix to make 2.6.3, so that's what I set it to, though I'm sure you'll change that if it was presumptuous of me.
I don't want to second guess you too much, because I don't know the code for Cyberduck well (or at all really), and am only a Java programmer in the loosest sense of the term...
When creating a bookmark with a '/' character in the nickname field, Cyberduck will fail to allow you to drag the file to the Finder.
Unfortunately, it does not give any indication that it has failed, it simply doesn't create the file.
-(Additional testing shows that if a folder matching the pre-/ portion of the nickname exists, Cyberduck will create a file inside that folder with only the post-/ portion of the nickname as the bookmark filename. - I.e. Cyberduck is not escaping path components well in its file creation/naming routine.)*
The fix would appear to simply be checking for the '/' character in nicknames before completing the drag operation and converting any and all of them that are found into ':' characters (which the Finder represents as '/' to the user) so that the bookmark is created in the expected location with it's appropriate name.
-(Bookmarks with ':' characters might ought to be a special case too due to their special history as path separators in old Mac OS versions... but they appear to work just fine as is and merely appear in the Finder with a '/' instead of the ':' as might be expected anyway. So it isn't really "necessary" to handle them in any special way.)*
Optionally, if there is some exceptional problem I haven't foreseen in fixing this, then there should at the very least be a warning message generated by Cyberduck if dragging the bookmark fails. Currently, absolutely nothing happens at the end of the drag operation, and that is not good for the user experience.
The text was updated successfully, but these errors were encountered: