Cyberduck Mountain Duck CLI

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#9603 closed enhancement (fixed)

Uncomfirmed reads are unbounded

Reported by: jbaranick Owned by: dkocher
Priority: normal Milestone: 5.0.9
Component: sftp Version: 5.0
Severity: normal Keywords:
Cc: Architecture:
Platform:

Description (last modified by jbaranick)

If the file being downloaded is very large the number of unconfirmed reads is effectively unbounded. For example, when the file is 1.3GB, the number of unconfirmed reads is set to 39K. This results in the client submitting 39K calls to the server, updating the progress to look like the download is done, and then failing when some of the calls don't get responses in time. As far as I can tell, there is no way for the server to push back against these requests. As such, Cyberduck should limit the number of unconfirmed reads to something more reasonable, for example 1K.

FYI, the command like SFTP client supports 64 unconfirmed requests by default:

~ ❯❯❯ sftp -R                                                                                                                
 -- number of outstanding requests (default: 64)

Capping this at a reasonable number like 64 also means that when you click "stop" that it stops very quickly rather than taking a while to drain all of the unconfirmed reads.

Change History (7)

comment:1 Changed 2 years ago by dkocher

  • Milestone set to 5.1
  • Owner set to dkocher
  • Status changed from new to assigned

comment:2 Changed 2 years ago by jbaranick

  • Description modified (diff)

comment:3 Changed 2 years ago by jbaranick

  • Description modified (diff)

comment:4 Changed 2 years ago by jbaranick

  • Description modified (diff)

comment:5 Changed 2 years ago by dkocher

  • Summary changed from Uncomfirmed Reads are Unbounded to Uncomfirmed reads are unbounded
  • Type changed from defect to enhancement

comment:6 Changed 2 years ago by dkocher

  • Resolution set to fixed
  • Status changed from assigned to closed

In r21091.

comment:7 Changed 2 years ago by dkocher

  • Milestone changed from 5.1 to 5.0.9
Note: See TracTickets for help on using tickets.
swiss made software