Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comparison fails to check checksum, resorts to file size instead #9648

Closed
cyberduck opened this issue Aug 8, 2016 · 2 comments
Closed

Comparison fails to check checksum, resorts to file size instead #9648

cyberduck opened this issue Aug 8, 2016 · 2 comments
Assignees
@dkocher
Labels
bug cli Command Line Interface wontfix
Milestone
5.1

Comments

@cyberduck
Copy link
Collaborator

7d7644c created the issue

I'm attempting to synchronize a local directory with a WebDAV directory, using --existing compare. From the debug output, it looks like it's not checking checksums, but relying instead on file sizes. If I'm interpreting the source correctly, this only occurs when Cyberduck is unable to get a checksum either from the remote or the local file.

I think these are the relevant lines from the debug output:

2016-08-08 16:39:52,962 [background-1] DEBUG ch.cyberduck.core.synchronization.SizeComparisonService - Compare size for PathAttributes{accessed=-1, size=5282, modified=1470683902000, created=-1, owner='null', group='null', permission=--, acl={}, checksum='null', etag='8def6a292b5255efebcf616ece1b99d3', storageClass='null', encryption='null', versionId='null', duplicate=false, revision=0, region='null', metadata={}} with LocalAttributes{checksum='null', timestamp=1470683833000, permission=--------- (0)}
2016-08-08 16:39:52,966 [background-1] INFO  ch.cyberduck.core.transfer.upload.CompareFilter - Skip file Path{path='/dav/template/Panels/HTMLHead.html', type=[file]} with comparison equal
2016-08-08 16:39:52,967 [background-1] INFO  ch.cyberduck.core.worker.AbstractTransferWorker - Skip file Path{path='/dav/template/Panels/HTMLHead.html', type=[file]} by filter ch.cyberduck.core.transfer.upload.CompareFilter@4b5074a3 for transfer TransferCallable{file=Path{path='/dav/template/Panels/HTMLHead.html', type=[file]}, local=FinderLocal{bookmark=null, path='/Users/dstaley/Documents/git/github.com/maruccisports/maruccisports.com/dist/Panels/HTMLHead.html'}}
@cyberduck
Copy link
Collaborator Author

@dkocher commented

This is a regression from #8798.

@cyberduck
Copy link
Collaborator Author

@dkocher commented

Unfortunately there is no HTTP specification that would allow us to be sure that the checksum in the ETag is actually a digest of the file.

@iterate-ch iterate-ch locked as resolved and limited conversation to collaborators Nov 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dkocher dkocher

Labels
bug cli Command Line Interface wontfix
Projects
None yet
Milestone
5.1
Development

No branches or pull requests
2 participants
@dkocher @cyberduck