New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Manta Object Store #9711
Comments
This is certainly possible but we would need some more users to vote this up to justify the effort. |
Hey there, Tomas from Joyent here, I've been using Cyberduck for years now and want to contribute to the project. I'm researching what it would take to implement this and had a look at ticket #9799 along with the associated changeset which added support for Microsoft OneDrive. After reviewing the changes and getting project building locally, I'm interested in implementing a storage provider for Manta within Cyberduck. Following the example of 71fd632, it looks like the steps for adding a new provider is as follows:
Please let me know if I've missed any critical details or there are any points in need of clarfication. The divergence in terminology for the authentication secret stems from the fact that authentication for Manta relies on a combination of username and an SSH Key fingerprint for a key that has previously been uploaded to the Manta instance in use (see Setting Up Your Environment in the Manta documentation for details). Since Cyberduck provides a dropdown field for supplying an SSH Private Key in addition to text input for passwords there is some ambiguity regarding the best approach to take, please see Question 1 for some proposals about how to handle this. Questions:
|
Fixed the sonar link to point to (https://sonar.iterate.ch/). |
The codestyle is part of the project in the |
I would suggest to move the client-side encryption support in Manta to a different ticket. Our Cryptomator integration is now finished and will be part of 6.0 available later today. |
For the ambiguity for the SSH key fingerprint required you will want to at least override |
You analysis about what is to implement is right. Don't hesitate to ping me for any further clarifications. |
Work on this is progressing though I've got two questions thus far: When attempting to build and run the project in Xcode (using Cyberduck.xcodeproj to open the project) the application crashes immediately with the error pasted below. I haven't had a chance to debug it further but noticed there was no output in the Xcode console and am not familiar with logging in Objective-C. Any suggestions?
When attempting to turn on debugging using the
Not sure how to resolve the first issue further without getting past the second. |
Create a debug configuration |
I never run the project from XCode – the build in XCode is partial and only covers the native libraries. You will have to run You can then execute the Cyberduck.app binary in |
We are now mirroring to https://github.com/iterate-ch/cyberduck to make contributions easier. |
Thanks for all the help so far! Definitely getting closer since
Thankfully
The error specifically occurs on the last line in |
Please try running the install phase with |
That did the trick! A warning came up about "App Transport Security" but everything seems to work and the manta endpoints are all https so I don't think it'll cause any issues. Thanks! Replying to [comment:17 dkocher]:
|
I'm nearing completion and will be ready to submit my changes as soon a I resolve an issue with Manta subusers, would a pull request on Github work or is there some other process for submitting contributions? |
Replying to [comment:19 tjcelaya]:
A pull request on GitHub works just great. |
Now in feature/TRAC-9711. |
java-manta
|
Please try the branch (https://github.com/iterate-ch/cyberduck/tree/feature/TRAC-9711) and install the build tasks from (https://github.com/loresoft/msbuildtasks). |
Thanks, I installed the latest msbuildtasks MSI and am getting further into the build but have encountered some confusing errors. I've attached them as windows-build-failure-2017-09-26.log. Which version of the .NET Framework and Windows SDK is used for builds? I discovered that I needed to install the Windows 8 SDK (https://developer.microsoft.com/en-us/windows/downloads/windows-8-sdk) based on the error message that occurred after adding msbuildtasks but the new errors seem to be related to compiler versions? In order to install as few conflicting version of .NET as possible I am using the MSBuild executable from the .NET Framework installed by Windows 8 SDK ( added |
Using MSBuild from Please install Visual Studio 2017 from https://www.visualstudio.com/en/vs/ and include following "additional items" upon installation.
Additional items required to build Cyberduck for Windows or Cyberduck for Windows Store:
For more information about workloads and additional items in visual studios new installer go to https://docs.microsoft.com/en-us/visualstudio/install/modify-visual-studio You will, however, get additional errors after building as we create an installer just after building. You can ignore those errors. |
The Visual Studio 2017 installation (w/ Windows 10 SDK (10.0.14393.0)) seems to have addressed some compiler issues. Unfortunately I've encountered a new error. Apologies for stumbling on what are most likely very simple issues, I really appreciate the assistance! The latest errors have been attached as |
Replying to [comment:28 tjcelaya]:
We have updated the build instructions at (https://github.com/iterate-ch/cyberduck/blob/master/README.md). Please install Bonjour SDK for Windows or exclude the |
Thanks for all the help! It looks like I'm down to one last issue, actually loading the new In search of a commonality between the protocols which did load I tried Basically, how do I make sure the Windows build can use the new protocol? |
I have fixed the missing dependency in the feature brach. |
Thanks again for all the assistance! I'm doing a final pass of acceptance testing now that Windows builds are picking up our |
I'm not sure why this behavior wasn't occurring on the feature/TRAC-9711 branch but it seems like the password entry field is now disabled when trying to log in with a passphrase-protected key. Still bisecting the commits between master and the previous working version to figure out where the bug was introduced so I can provide more detail about the issue. |
Replying to [comment:35 tjcelaya]:
|
Replying to [comment:35 tjcelaya]:
|
Thanks for the quick resolution. I opened a PR to address the fact that the private key file dropdown is enabled and might be confusing (plus a URL encoding issue) |
Manta is an open source object store like S3 or Swift. It is widely in use and will be quite ubiquitous now that Samsung has purchased Joyent (the creators of Manta).
This ticket is to request that support for Manta be added to CyberDuck.
There is a Java SDK available for Manta.
Attachments
Info.plist.debug
(15.5 KiB)windows-build-failure-2017-09-26.log
(194.2 KiB)windows-build-failure-2017-09-27.log
(15.1 KiB)windows-build-failure.log
(43.2 KiB)The text was updated successfully, but these errors were encountered: