Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crashing when reading private keys from Keychain (macOS) #9873

Open
cyberduck opened this issue Mar 8, 2017 · 3 comments
Open

Crashing when reading private keys from Keychain (macOS) #9873

cyberduck opened this issue Mar 8, 2017 · 3 comments
Assignees

Comments

@cyberduck
Copy link
Collaborator

567067d created the issue

Steps to reproduce:

  1. Click on Add new bookmark
    or
  2. Select a bookmark
  3. Click on Edit bookmark

Result:
Program crashes immediately. When the add bookmark button was click, a new empty bookmark is visible after a restart of the program.

Crash happens in the 5.3.x branch, and on 6.0.0. On 5.2.2, the bookmark window still works.


Attachments

@cyberduck
Copy link
Collaborator Author

@dkocher commented

Exception Type:        EXC_BAD_ACCESS (SIGABRT)
Exception Codes:       KERN_PROTECTION_FAILURE at 0x000000010c8f8000
Exception Note:        EXC_CORPSE_NOTIFY

VM Regions Near 0x10c8f8000:
    __LINKEDIT             000000010c8e7000-000000010c8f8000 [   68K] r--/rwx SM=COW  /Applications/Cyberduck.app/Contents/PlugIns/Runtime.jre/Contents/Home/lib/libjava.dylib
--> VM_ALLOCATE            000000010c8f8000-000000010c8f9000 [    4K] r--/rwx SM=PRV  
    mapped file            000000010c8f9000-000000010c901000 [   32K] rw-/rwx SM=PRV  pl��

Application Specific Information:
Performing @selector(addBookmarkButtonClicked:) from sender NSButton 0x600000159440
*** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '*** -[__NSArrayM setObject:atIndex:]: object cannot be nil'
terminating with uncaught exception of type NSException
abort() called

Application Specific Backtrace 1:
0   CoreFoundation                      0x00007fffa155ce7b __exceptionPreprocess + 171
1   libobjc.A.dylib                     0x00007fffb6146cad objc_exception_throw + 48
2   CoreFoundation                      0x00007fffa14ebd3a -[__NSArrayM setObject:atIndex:] + 426
3   libosx.dylib                        0x000000011849b2aa Java_apple_security_KeychainStore__1scanKeychain + 358
4   ???                                 0x000000011a32f9f4 0x0 + 4734515700
5   ???                                 0x000000011a3202bd 0x0 + 4734452413

Thread 0 Crashed:: Dispatch queue: com.apple.main-thread
0   libsystem_kernel.dylib        	0x00007fffb6b58dd6 __pthread_kill + 10
1   libsystem_pthread.dylib       	0x00007fffb6c44787 pthread_kill + 90
2   libsystem_c.dylib             	0x00007fffb6abe420 abort + 129
3   libc++abi.dylib               	0x00007fffb561985a abort_message + 266
4   libc++abi.dylib               	0x00007fffb563ec4f default_terminate_handler() + 267
5   libobjc.A.dylib               	0x00007fffb6148f1e _objc_terminate() + 103
6   libc++abi.dylib               	0x00007fffb563bd69 std::__terminate(void (*)()) + 8
7   libc++abi.dylib               	0x00007fffb563b7de __cxa_throw + 121
8   libobjc.A.dylib               	0x00007fffb6146dd6 objc_exception_throw + 345
9   com.apple.CoreFoundation      	0x00007fffa14ebd3a -[__NSArrayM setObject:atIndex:] + 426
10  libosx.dylib                  	0x000000011849b2aa Java_apple_security_KeychainStore__1scanKeychain + 358
11  ???                           	0x000000011a32f9f4 0 + 4734515700
12  ???                           	0x000000011a3202bd 0 + 4734452413
13  ???                           	0x000000011a3202bd 0 + 4734452413
14  ???                           	0x000000011a3202bd 0 + 4734452413
15  ???                           	0x000000011a320040 0 + 4734451776
16  ???                           	0x000000011a320040 0 + 4734451776
17  ???                           	0x000000011a3187a7 0 + 4734420903
18  libjvm.dylib                  	0x000000010bbc79d6 JavaCalls::call_helper(JavaValue*, methodHandle*, JavaCallArguments*, Thread*) + 1710
19  libjvm.dylib                  	0x000000010bdac6c4 Reflection::invoke(instanceKlassHandle, methodHandle, Handle, bool, objArrayHandle, BasicType, objArrayHandle, bool, Thread*) + 3602
20  libjvm.dylib                  	0x000000010bdacbf8 Reflection::invoke_method(oopDesc*, Handle, objArrayHandle, Thread*) + 364
21  libjvm.dylib                  	0x000000010bc1fdb8 JVM_InvokeMethod + 358
22  ???                           	0x000000011aa9d86d 0 + 4742305901
23  ???                           	0x000000011aa2017c 0 + 4741792124


@cyberduck
Copy link
Collaborator Author

@dkocher commented

Please reopen if still reproducible.

@iterate-ch iterate-ch locked as resolved and limited conversation to collaborators Nov 26, 2021
@dkocher dkocher self-assigned this May 23, 2023
@dkocher
Copy link
Contributor

dkocher commented May 25, 2023

As a workaround set the following hidden configuration option to disable lookup of private keys in the keychain.

defaults write ~/Library/Preferences/ch.sudo.cyberduck.plist connection.ssl.keystore.type ""

@dkocher dkocher reopened this Jun 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants